Skip to content

Additional fix dict updates#1

Merged
mtreinish merged 4 commits into
mtreinish:fix-dict-access-pulsefrom
DanPuzzuoli:additional-fix-dict-updates
May 11, 2020
Merged

Additional fix dict updates#1
mtreinish merged 4 commits into
mtreinish:fix-dict-access-pulsefrom
DanPuzzuoli:additional-fix-dict-updates

Conversation

@DanPuzzuoli
Copy link
Copy Markdown

Summary

Made the following changes:

  • Further updates to duffing_model_generators and corresponding tests to switch over to using UchannelLO instead of the dictionary version.
  • Added additional test in test_duffing_model_generators to call PulseSystemModel.calculate_channel_frequencies - this test will now catch any errors resulting from duffing_model_generators using an invalid format for specifying u channel los.
  • Fixed a bug found in writing the above test: in duffing_model_generators, if a coupling strength was 0.0 it would cause an error as it was ultimately being input as None when compiling the PulseSystemModel object, due to incorrect use of python's or function.
  • Modified a couple parts of @mtreinish 's PR to directly construct UchannelLO objects (as opposed to using the from_dict method.

Copy link
Copy Markdown
Owner

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing these places too

@mtreinish mtreinish merged commit cb764e1 into mtreinish:fix-dict-access-pulse May 11, 2020
@DanPuzzuoli DanPuzzuoli deleted the additional-fix-dict-updates branch June 4, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants